On Mon, Sep 29, 2008 at 12:04:22PM +0100, ext Mark Brown wrote: > On Mon, Sep 29, 2008 at 03:18:32PM +0530, Arun KS wrote: > > Adding ASOC machine driver for osk > > This also looks good - a couple of very minor points below: > > BTW, it's "ASoC" not "ASOC". > > > + * osk.c -- SoC audio for 5912 OSK > > I don't know anything in particular about these boards but perhaps it > would be a good idea to include the part number in the name in case > someone decides it's a good idea to make an OSK for another OMAP > variant? Google suggests that the board is referred to as the OSK > generally so probably not but I thought I'd better ask - though you do > use 5192OSK as well. yes, and they already exist. We had 2430osk as well ;-) -- balbi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
