On Mon, Sep 29, 2008 at 03:18:32PM +0530, Arun KS wrote: > Adding ASOC machine driver for osk This also looks good - a couple of very minor points below: BTW, it's "ASoC" not "ASOC". > + * osk.c -- SoC audio for 5912 OSK I don't know anything in particular about these boards but perhaps it would be a good idea to include the part number in the name in case someone decides it's a good idea to make an OSK for another OMAP variant? Google suggests that the board is referred to as the OSK generally so probably not but I thought I'd better ask - though you do use 5192OSK as well. > + /* Set the codec system clock for DAC and ADC */ > + err = snd_soc_dai_set_sysclk(codec_dai, 0, 12000000, SND_SOC_CLOCK_IN); Here you hardcode the clock to 12MHz... > +#define CODEC_CLOCK 12000000 ...but here you have a #define for it. It'd be better to put the define at the top of the file and use it in the hw_params() function as well. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
