On Tue, Apr 16, 2024 at 07:45:21AM +0000, Xu, Baojun wrote: > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Sent: 09 April 2024 21:02 > > On Tue, Apr 09, 2024 at 10: 48: 13AM +0800, Baojun Xu wrote: > > On Tue, Apr 09, 2024 at 10:48:13AM +0800, Baojun Xu wrote: ... > > > @@ -39,6 +39,7 @@ snd-hda-scodec-cs35l56-spi-objs := cs35l56_hda_spi.o > > > snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o > > > snd-hda-scodec-component-objs := hda_component.o > > > snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o > > > +snd-hda-scodec-tas2781-spi-objs := tas2781_hda_spi.o tas2781_spi_fwlib.o > > > > Actually these 'objs' has to be 'y', can you fix it in the prerequisite patch? > > Do you mean set CONFIG_SND_HDA_SCODEC_TAS2781_SPI=y in .config? No. I mean the Kconfig syntax in use. -objs is for user space tools. Kernel code should use -y in this case. > It's m now. > > > Also wondering why fwlib is only a requirement for SPI. How does I²C work? > > Because in I2C mode, one probed device driver will support all devices, > firmware binary is only one file, include all of devices. > But in SPI mode, multi driver probed, so we use single firmware binary for > every spi device. But does I²C version still need the firmware? Can't the FW handling be factored out to a single module for both? -- With Best Regards, Andy Shevchenko
