On Thu, 01 Feb 2024 11:36:11 +0100, Alexander Tsoy wrote: > > В Чт, 01/02/2024 в 15:06 +0800, vincenttew пишет: > > Behringer UMC202HD and UMC404HD take some times to validate the clock > > source. To prevent more DAC have the same delay which return the > > false > > in the first time, remove the USB id check to have a chance to retry > > the > > clock validate. > > > > Signed-off-by: vincenttew <vincenttew@xxxxxxxxxx> > > Thank you for the patch! My thought about this change: > - Retrying clock source validation probably make sense only in the case > of Internal clock. But I'm not sure. It's an interesting point. > - If we want to make this a standard driver behaviour, then the code > needs to be moved out of the quirk function IMO. I'm a bit afraid of applying this unconditionally to all cases. At first, we can start with the vendor matching (e.g. MOTU and Behringer) to apply it... thanks, Takashi
