On Wed, 31 Jan 2024 21:28:48 +0100, rp@xxxxxx wrote: > > Problems: > - PioneerDJ DDJ-1000 audio channels are not recognized. > - Jog dial displays are showing permanently "NO AUDIO DRIVER" > > The attached patch fixes this. > The jog displays and all output and input channels are working now. > > Signed-off-by: Ralf Pachali <rp@xxxxxx> The code changes look OK, but the submission has a minor problem. > --- sound/usb/quirks-table.h > +++ sound/usb/quirks-table.h Please create a patch that is applied with -p1, just like what git format-patch provides. Also, when applied to git tree, there is "attached patch". It'll be the commit log text, hence better to rephrase the texts to fit as a git commit log. Last but not least, please use the "From:" line aligned with your Signed-off-by line. If you don't want to change the mailer setup, put the From: line in the patch itself, so that it's taken at applying. Could you address those and resubmit? thanks, Takashi
