On 2023/12/21 21:58, Mark Brown wrote: > On Thu, Dec 21, 2023 at 01:53:00PM +0000, Conor Dooley wrote: >> On Thu, Dec 21, 2023 at 11:32:22AM +0800, Xingyu Wu wrote: > >> > + cdns,i2s-max-channels: >> > + description: | >> > + Number of I2S max stereo channels supported by the hardware. >> > + $ref: /schemas/types.yaml#/definitions/uint32 >> > + minimum: 1 >> > + maximum: 8 > >> Mark, is there no common property for this kind of thing? That said, >> there's one device here so the number is known at present. >> Another note, this property is not required, so it should have a >> default. > > I wouldn't expect this to be a property in the first place, as currently > presented this is specific to a single instance of the IP in a single > SoC. In general this is something that is obvious from the compatible > and doesn't need a property, it's only plausibly useful for Cadence and > Designware which is a very short list of vendors. The Cadence I2S can support 8 channels. But on the JH8100 SoC, two instances of this just provide 4 channels to use, one just provides 2 channels, and the other one can provide 8 channels. Should I use the property name of 'jh8100,i2s-max-channels' instead for some special instances on the JH8100 SoC? Best regards, Xingyu Wu
