Re: [PATCHv3 10/10] ASoC: bindings: fsl-asoc-card: add compatible for generic codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, 18 December, 2023 15:04:42, Mark Brown wrote:
> On Mon, Dec 18, 2023 at 10:51:44AM +0100, Krzysztof Kozlowski wrote: 
> > On 18/12/2023 10:49, Elinor Montmasson wrote: 
> > Also, you add several new properties, so I really expect either 
> > converting old binding to DT schema first or adding new device in DT 
> > schema format. 
> 
> So long as the binding conversion can go through quickly... 

I can take some time next week to do the conversion, then I'll send this
additional commit in a v4 patch series.

> > > Is this compatible string not suitable ? 
> > > Should we rename it to something else, like "fsl,imx-audio-no-codec" ? 
> 
> > Maybe Mark or Rob will help here, but for me "imx-audio" is just way too 
> > generic. 
> 
> I think it's fine.

I will keep the compatible name to "fsl,imx-audio-generic" for now,
but if it is needed to change it, tell me and I will do it in
the v4 patch series.

Thank you for the review.

Best regards,
Elinor Montmasson



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux