Hello, > > Add documentation about new dts bindings following new support > > for compatible "fsl,imx-audio-generic". > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. I saw that most of the commits use "ASoC: dt-bindings:" prefix, but commits related to "fsl-asoc-card.txt" use "ASoC: bindings:" prefix. Should I follow the general style or the file style ? > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Sorry for the mistake, I will resend patches with the correct list from the get_maintainers.pl script. > > Some CPU DAI don't require a real audio codec. The new compatible > > "fsl,imx-audio-generic" allows using the driver with codec drivers > > SPDIF DIT and SPDIF DIR as dummy codecs. > > It also allows using not pre-configured audio codecs which > > don't require specific control through a codec driver. > > > > The new dts properties give the possibility to set some parameters > > about the CPU DAI usually set through the codec configuration. > > > > Signed-off-by: Elinor Montmasson <elinor.montmasson@xxxxxxxxxxxxxxxxxxxx> > > Co-authored-by: Philip-Dylan Gleonec <philip-dylan.gleonec@xxxxxxxxxxxxxxxxxxxx> > > --- > > .../bindings/sound/fsl-asoc-card.txt | 28 ++++++++++++++++++- > > 1 file changed, 27 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt > > index 4e8dbc5abfd1..f137ef2154e3 100644 > > --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt > > +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt > > @@ -17,6 +17,9 @@ Note: The card is initially designed for those sound cards who use AC'97, I2S > > and PCM DAI formats. However, it'll be also possible to support those non > > AC'97/I2S/PCM type sound cards, such as S/PDIF audio and HDMI audio, as > > long as the driver has been properly upgraded. > > + To use CPU DAIs that do not require a codec such as an S/PDIF controller, > > + or to use a DAI to output or capture raw I2S/TDM data, you can > > + use the compatible "fsl,imx-audio-generic". > > > > > > The compatible list for this generic sound card currently: > > @@ -48,6 +51,8 @@ The compatible list for this generic sound card currently: > > > > "fsl,imx-audio-nau8822" > > > > + "fsl,imx-audio-generic" > > Generic does not look like hardware specific. Even if our end goal is to use it with the S/PDIF controller, this new support can be used with different hardware that doesn't require a codec. Thus, we don't really want to specify "spdif" in it. Is this compatible string not suitable ? Should we rename it to something else, like "fsl,imx-audio-no-codec" ? Best regards, Elinor Montmasson
