Thanks for your reply, I will generate the pach based on the latest sound git tree. Wei -----Original Message----- From: Takashi Iwai [mailto:tiwai@xxxxxxx] Sent: Thursday, September 04, 2008 3:04 PM To: Pavel Hofman Cc: Wei Ni; Peer Chen; alsa-devel; linux-kernel; akpm Subject: Re: [PATCH] add the nvidia HDMI codec driver for MCP77/79 At Wed, 03 Sep 2008 14:11:16 +0200, Pavel Hofman wrote: > > > >> ...... > >> According to these codes, It only can get the realtek codec and can not > >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 > >> I think if remove "if (!audio_codecs)", it will be better, and I only > >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 > > > > Well, the check is there for a good reason. > > > > There are many machines with broken BIOS reporting the 4th slot > > available although it isn't actually. It's a workaround to skip such > > a bogus information. So, it cannot be changed so easily. > > > > We need to sort out this in a better way... Oh well. > > > Please, please, put the above information as a comment to the respective > place. These "hacks" should be commented :) I changed that code yesterday with a little bit more comment. Wei, Peer, could you regenerate the patch based on the latest sound git tree? git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git or use the snapshot tarball from ftp://ftp.kernel.org/pub/linux/tiwai/snapshot/ This already contains the fix for the 4th slot probe on Nvidia chipset. thanks, Takashi ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
