-----Original Message-----
From: Mark Brown <broonie@xxxxxxxxxx>
Sent: Wednesday, November 1, 2023 9:01 PM
To: Jack Yu <jack.yu@xxxxxxxxxxx>
Cc: lgirdwood@xxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; lars@xxxxxxxxxx; Flove(HsinFu) <flove@xxxxxxxxxxx>; Oder Chiou <oder_chiou@xxxxxxxxxxx>; Shuming [范書銘] <shumingf@xxxxxxxxxxx>; Derek [方德義] <derek.fang@xxxxxxxxxxx>
Subject: Re: [PATCH] ASoC: rt5682s: Add LDO control for dacref
On Wed, Nov 01, 2023 at 02:52:20AM +0000, Jack Yu wrote:
> > > +/* LDO output select */
> > > +static const char * const rt5682s_ldo_output_select[] = {
> > > + "1.607V", "1.5V", "1.406V", "1.731V"
> > > +};
> > This feels like something that might be a better fit for firmware
> > based selection - how would someone set a value for this, and why
> > might it vary at runtime? I'm a bit unclear as to what the control
> > does so this might be the best thing but perhaps not.
> This control is added for specific customers, it won't be changed
> during runtime, but will be set in the initialization regarding to
> different customers, they'll set it in their own ucm and have already been verified by customers.
That sounds like it should come from the firmware then if it's supposed to be fixed for a given system (which is what the above sounds like).
Yes, maybe it's better to be configured by firmware, but there is no firmware to set this LDO setting in this case,
so we provide this control for customer to do their own setting in UCM.
