> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Tuesday, October 31, 2023 9:30 PM
> To: Jack Yu <jack.yu@xxxxxxxxxxx>
> Cc: lgirdwood@xxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; lars@xxxxxxxxxx;
> Flove(HsinFu) <flove@xxxxxxxxxxx>; Oder Chiou <oder_chiou@xxxxxxxxxxx>;
> Shuming [范書銘] <shumingf@xxxxxxxxxxx>; Derek [方德義]
> <derek.fang@xxxxxxxxxxx>
> Subject: Re: [PATCH] ASoC: rt5682s: Add LDO control for dacref
>
> On Tue, Oct 31, 2023 at 02:08:10AM +0000, Jack Yu wrote:
>
> > +/* LDO output select */
> > +static const char * const rt5682s_ldo_output_select[] = {
> > + "1.607V", "1.5V", "1.406V", "1.731V"
> > +};
>
> This feels like something that might be a better fit for firmware based
> selection - how would someone set a value for this, and why might it vary at
> runtime? I'm a bit unclear as to what the control does so this might be the
> best thing but perhaps not.
This control is added for specific customers, it won't be changed during runtime,
but will be set in the initialization regarding to different customers,
they'll set it in their own ucm and have already been verified by customers.
