On 26/10/2023 14:05, Mark Brown wrote:
On Wed, Oct 25, 2023 at 02:43:28PM +0200, Johan Hovold wrote:
On Wed, Oct 25, 2023 at 01:36:14PM +0100, Mark Brown wrote:
On Wed, Oct 25, 2023 at 09:57:12AM +0200, Johan Hovold wrote:
I understand Srini has looked at this but has not yet been able to come
up with a generic implementation. Would it be possible to merge the two
codec fixes as an interim workaround for 6.7?
You're talking about two fixes here but this is a 4 patch series...
Yes, sorry, I should have been more clear. I was talking about the codec
fixes so that's patch 3 and 4.
I believe the first two have already been applied.
So, having gone and fished the series out of lore to look at what the
patches are I'm pretty surprised here, it's been about six months since
the original discussion and I'd not have expected this to be such a
difficult thing to do, or at least that any issues would have been
flagged up by now. What are the issues that have been encountered here?
The approach I tried was to reuse the existing
snd_soc_dai_digital_mute() from generic snd_soc_pcm_dai_trigger()
The issue is that prepare also unmutes the stream which is why moving
this to generic code is not helping in this setup.
To overcome this I have added a flag in snd_soc_dai_ops which seems to
have helped
Let me send that patch as RFC for more discussion.
thanks,
Srini
