On Mon, 2008-09-01 at 14:52 +0100, Alan Horstmann wrote: > We have just started trying this out as an alternative to i2c, and picked out > the following: > > On Wednesday 27 August 2008 10:39, Bryan Wu wrote: > > -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) > > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined > > (CONFIG_SND_SOC_WM8731_SPI) > > I think this needs extra brackets round the ||'s before the && thus: > > > +#if (defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)) && !defined > > (CONFIG_SND_SOC_WM8731_SPI) > > in order to force use of SPI when (CONFIG_SND_SOC_WM8731_SPI) and (CONFIG_I2C) > are both defined. Or have we misunderstood the intention? This is in 2 > other places also in the patch. > It may be simpler to only have CONFIG_SND_SOC_WM8731_SPI and CONFIG_SND_SOC_WM8731_I2C definitions for all the codec drivers. These would be set by machine Kconfig. Liam _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
