On Fri, 6 Oct 2023 13:23:48 +0300 Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Tony Lindgren <tony@xxxxxxxxxxx> [230921 20:34]: > > * Péter Ujfalusi <peter.ujfalusi@xxxxxxxxx> [230920 17:40]: > > > It is not the parent's fck, it is the PRCM clock which is selected as > > > the sourcee of the clock generator (CLKS) for BCLK/FSYNC. That is the > > > functional clock as well for the McBSP instance. > > > > Oh OK > > > > > Out of reset it is using the PRCM source which is fine in all current users. > > > I would do this fix or workaround in a different way: instead of > > > ignoring the error, avoid it in the first place. Do nothing if the > > > already selected clock is requested. > > > That would remove the error and will fail in case the reparenting is not > > > working -> boards will know this and might be able to do something about > > > it in a reasonable way. > > Here's what I think the regression fix for omap4 clocks would be, the > old main_clk is not the same as the module clock that we get by default. > If this looks OK I'll do a similar fix also for omap5. > > Or is something else also needed? > hmm, audio output works, the waring is away, but something new is here: omap-mcbsp 40124000.mcbsp: Runtime PM usage count underflow! # cat /sys/bus/platform/devices/40124000.mcbsp/power/runtime_status active even with no sound. Regards, Andreas
