On 9/16/23 22:25, Javier Carrasco wrote:
Removing an unused variable is actually removing a blank line from a logical point of view. Is an extra patch not overkill considering that it cannot affect the code behavior?
Well, no, it is not, as the line is not blank (nothing except removing a blank line could be considered as blank line removal) :) And an extra patch is not an overkill in case if you are separating logical changes.
However, rules may vary from one subsystem to another, so it is up to Shuah to decide take this patch or not. My opinion is that such changes should be separated into different patches.
