Thank you very much for your review, but I have a question that I would like to consult On 13/09/2023 09:03, krzysztof.kozlowski@xxxxxxxxxx wrote: > On 12/09/2023 08:58, wangweidong.a@xxxxxxxxxx wrote: >> From: Weidong Wang <wangweidong.a@xxxxxxxxxx> >> >> Adds properties to "awinic,aw88395" to make files more complete >> >> Signed-off-by: Weidong Wang <wangweidong.a@xxxxxxxxxx> >> --- >> .../bindings/sound/awinic,aw88395.yaml | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> index 4051c2538caf..4965aa4a5370 100644 >> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml >> @@ -32,11 +32,28 @@ properties: >> reset-gpios: >> maxItems: 1 >> >> + awinic,audio-channel: >> + description: >> + It is used to distinguish multiple PA devices, so that different >> + configurations can be loaded to different PA devices >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + minimum: 0 >> + maximum: 7 >> + >> + awinic,sync-flag: >> + description: >> + Flag bit used to keep the phase synchronized in the case of multiple PA >> + $ref: /schemas/types.yaml#/definitions/uint32 > Looks like bool, not uint32. If you made it uint32 for some future > purpose, then the name "flag" is misleading and anyway what would be the > third option here for sync? Thank you very much. Can I Change it to "$ref: /schemas/types.yaml#/definitions/bool"? Best regards, Weidong Wang
