Thank you very much for your review. On 13/09/2023 09:03, krzysztof.kozlowski@xxxxxxxxxx wrote: > On 12/09/2023 08:58, wangweidong.a@xxxxxxxxxx wrote: >> From: Weidong Wang <wangweidong.a@xxxxxxxxxx> >> >> Change "sound-channel" to "awinic,audio-channel" >> Change "aw88261_smartpa" to "aw88261" I'll add "This change is for consistency with yaml properties" to the commit message. >> - prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count); >> - if (!prof_name) { >> + ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name); >> + if (ret) { >> strscpy(uinfo->value.enumerated.name, "null", >> strlen("null") + 1); >> return 0; >> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261) >> u32 channel_value = AW88261_DEV_DEFAULT_CH; >> u32 sync_enable = false; >> >> - of_property_read_u32(np, "sound-channel", &channel_value); >> + of_property_read_u32(np, "awinic,audio-channel", &channel_value); >> of_property_read_u32(np, "sync-flag", &sync_enable); > What about this? This change is to be consistent with the name in the yaml file Best regards, Weidong Wang