On Sun, Sep 03, 2023 at 10:37:57PM +0800, Shenghao Ding wrote: > Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure > cs35l41_dev_name. ... > + /* exactly match either TXNW2781 or TIAS2781 */ > + /* the rest must be exact matching */ > + snprintf(tmp, sizeof(tmp), "-%s:00", "TXNW2781"); > + > + if (!strcmp(d + n, tmp)) > + return 1; > + > /* the rest must be exact matching */ > - snprintf(tmp, sizeof(tmp), "-%s:00", p->hid); > + snprintf(tmp, sizeof(tmp), "-%s:00", "TIAS2781"); Basically this should use acpi_dev_match infra like Intel drivers do. But I haven't read code deeply to understand if it's the case here or not. -- With Best Regards, Andy Shevchenko