On Sun, 03 Sep 2023 16:37:57 +0200, Shenghao Ding wrote: > > Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure > cs35l41_dev_name. Could you explain why you need to revert? That's the important piece. And, what is found in below... > --- > Changes in v1: > - Redefine tas2781_generic_fixup, remove hid param > - TIAS2781 has been used by our customers, see following dstd.dsl. We > have discussed this with them, they requested TIAS2781 must be > supported for the laptops already released to market, their new > laptops will switch to TXNW2781 > Name (_HID, "TIAS2781") // _HID: Hardware ID > Name (_UID, Zero) // _UID: Unique ID > Method (_SUB, 0, NotSerialized) // _SUB: Subsystem ID > { > If ((SPID == Zero)) > { > Return ("17AA3886") > } > > If ((SPID == One)) > { > Return ("17AA3884") > } ... such information should be mentioned in the changelog. It can be even commented in the code. Last but not least, if you do two things, split to two patches -- unless the rename is closely tied with the support of both IDs. thanks, Takashi