Re: [PATCH 1/2] ASoC: dmaengine: Drop unused iov_iter for process callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 31, 2023 at 03:04:56PM +0200, Takashi Iwai wrote:
> Passing the iov_iter to the process callback is rather buggy, as the
> iterator has been already processed for playback.  Similarly, it makes
> the copy for capture buggy after the process callback reading the
> iterator out.  Moreover, all existing process callbacks don't refer to
> the passed iterator at all.  So, it's better to drop the argument from
> the process callback.

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux