On Tue, Aug 29, 2023 at 06:02:51PM +0000, Biju Das wrote:
> > On Mon, Aug 28, 2023 at 07:00:03PM +0100, Biju Das wrote:
...
> > > - if (np) {
> > > - const struct of_device_id *of_id;
> > > -
> >
> > > + if (dev_fwnode(dev)) {
> >
> > Why do we need this at all?
> It is replacement for np.
I am questioning it's necessity to begin with (even before your patch).
> > > mcko = ak4642_of_parse_mcko(dev);
> > > if (IS_ERR(mcko))
> > > mcko = NULL;
> >
> > This can suffice on its own, right?
> >
> > Can be done in a separate change as a precursor to this one.
>
> Agreed.
--
With Best Regards,
Andy Shevchenko
