Hi Andy,
> Subject: Re: [PATCH v2] ASoC: ak4642: Simplify probe()
>
> On Mon, Aug 28, 2023 at 07:00:03PM +0100, Biju Das wrote:
> > Simpilfy probe() by replacing of_device_get_match_data() and id lookup
> > for retrieving match data by i2c_get_match_data() and replace
> > dev_err()->dev_err_probe().
>
> ...
>
> > - if (np) {
> > - const struct of_device_id *of_id;
> > -
>
> > + if (dev_fwnode(dev)) {
>
> Why do we need this at all?
It is replacement for np.
>
> > mcko = ak4642_of_parse_mcko(dev);
> > if (IS_ERR(mcko))
> > mcko = NULL;
>
> This can suffice on its own, right?
>
> Can be done in a separate change as a precursor to this one.
Agreed.
Cheers,
Biju
>
> > -
> > - of_id = of_match_device(ak4642_of_match, dev);
> > - if (of_id)
> > - drvdata = of_id->data;
> > - } else {
> > - const struct i2c_device_id *id =
> > - i2c_match_id(ak4642_i2c_id, i2c);
> > - drvdata = (const struct ak4642_drvdata *)id->driver_data;
> > }
>
> --
> With Best Regards,
> Andy Shevchenko
>
