Re: [PATCH v2 20/28] net: wan: Add framer framework support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +int framer_pm_runtime_get(struct framer *framer)
> +{
> +	int ret;
> +
> +	if (!framer)
> +		return 0;

Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.

       Andrew



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux