On Mon, Jul 10, 2023 at 03:37:59PM +0300, Andy Shevchenko wrote: > On Mon, Jul 10, 2023 at 12:22:59PM +0100, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 02:10:53PM +0300, Andy Shevchenko wrote: > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > > > > and kill the not used anymore definitions. ... > > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; > > What part of the above change is replacing _NO_ with _MUST_? > None, that's why assuming the split by name should be fine. That's what the above changelog sounds like it's trying to do (I'm not sure the change itself makes sense but the first thing I ran into when reviewing the patch), AFIACT you're missing a "from" in the changelog?
Attachment:
signature.asc
Description: PGP signature
