On Mon, Jul 10, 2023 at 12:22:59PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 02:10:53PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 10, 2023 at 02:08:00PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > > > > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > > > and kill the not used anymore definitions. > > > > > The above is not what this change does: > > > > How to improve it? I was sure that the form of "converting to something and > > > something" is clear... > > > A wild guess, maybe you meant to split to two changes, one per each macro group? > > No, doing TX and RX in one commit is fine. No, I meant one per _NO_ and _MUST_. > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; > > What part of the above change is replacing _NO_ with _MUST_? None, that's why assuming the split by name should be fine. -- With Best Regards, Andy Shevchenko
