On 7/23/08, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote: > > On 7/23/08, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > ...this doesn't just allow a custom machine driver, it requires that > > > something configures at least the machine name. That's not a problem > > > from the ASoC point of view but possibly from the PowerPC side? > > > You have to configure at least the name. Otherwise if the machine > > driver is the last to register, how do you know to hold off the final > > registration and wait for the machine driver to appear? > > > I understand why you have made this change but it's a substantial change > which should at least be documented in the changelog (I'd expect to see > some mention of how this is supposed to be configured, for example). > I'd also expect something to handle the existing user. This is a modification to Grant's new driver. Grant is the only other user. > > Like I said, I'm not entirely sure that you're supposed to be using this > driver if you want a machine driver: this is a machine driver and I'm > not sure if it's supposed to cover all cases or not. Grant? > > > > Or is it ok for me to change these after the platform device has been created? > > of_soc->dai_link.ops = machine_ops; > > of_soc->machine.name = machine_name; > > > No. > -- Jon Smirl jonsmirl@xxxxxxxxx _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
