On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote: > Allow a custom ASOC machine driver with soc-of-simple As with the clocking configuration: this looks fine from an ASoC point of view but please fix the checkpatch warnings. However... > /* Only register the device if both the codec and platform have > * been registered */ > - if ((!of_soc->device.codec_data) || (!of_soc->platform_node)) > + if ((!of_soc->device.codec_data) || (!of_soc->platform_node) || !machine_name) > return; ...this doesn't just allow a custom machine driver, it requires that something configures at least the machine name. That's not a problem from the ASoC point of view but possibly from the PowerPC side? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
