On 5/10/2023 3:48 PM, Krzysztof Kozlowski wrote:
On 10/05/2023 09:42, AS50 CTLin0 wrote:
On 5/10/2023 3:19 PM, Krzysztof Kozlowski wrote:
On 10/05/2023 05:44, David Lin wrote:
Convert the NAU8825 audio CODEC bindings to DT schema.
Signed-off-by: David Lin <CTLIN0@xxxxxxxxxxx>
---
Version your patches and provide changelog after ---.
If you just send the same with the same mistakes, that's a NAK.
I know your meanings is to show change log from v1 to v2, but I see
previous patch have other missing items.
I don't understand it. It does not matter what else is missing in
previous patch. You always must version them and always provide changelog.
Noted.
Therefore, I revise it and included your comments. Anyway, I can back to
previous patch and re-send v2 patch with changelog.
Paste it here (and in v3 of course).
Changes:
V1 -> V2:
- add interrupts properties
- add maximum to nuvoton,jack-insert-debounce and
nuvoton,jack-eject-debounce properites
- add a enum item for nuvoton,short-key-debounce properites
- add default value for most properites
- add maxItems to clocks properites and mclk entries to clock-names
properites
- refine wrong indentation from clocks and clock-names
- refine dts example for interrupts and clocks
- remove headset label from dts example
.../devicetree/bindings/sound/nau8825.txt | 111 --------
.../bindings/sound/nuvoton,nau8825.yaml | 242 ++++++++++++++++++
2 files changed, 242 insertions(+), 111 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/nau8825.txt
create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ nau8825@1a {
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
About node item, maybe I misunderstand your meanings.
When I change from headset: nau8825@1a to audio-codec: nau8825@1a, it
will have compiler error.
That's label, not nodename. Why would even this create a compile error?
if the label is change name from headset to audio-codec, it will caused
compiler errors with the following error "FATAL ERROR: Unable to parse
input tree".
So far, I don't know why label name will caused compiler error, but it
might be caused parse error by '-'.
So I use nau8825@1a to submit.However, when I see your latest comment, I
seems to understand your point for node name.
The final result will be codec@1a or audio-codec@1a, right?
Yes.
Best regards,
Krzysztof
Thanks for your guide. I will send the v3 with the changelog.
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
