On 10/05/2023 05:44, David Lin wrote:
> Convert the NAU8825 audio CODEC bindings to DT schema.
>
> Signed-off-by: David Lin <CTLIN0@xxxxxxxxxxx>
> ---
Version your patches and provide changelog after ---.
If you just send the same with the same mistakes, that's a NAK.
> .../devicetree/bindings/sound/nau8825.txt | 111 --------
> .../bindings/sound/nuvoton,nau8825.yaml | 242 ++++++++++++++++++
> 2 files changed, 242 insertions(+), 111 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/nau8825.txt
> create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8825.yaml
>
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + nau8825@1a {
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
