On Fri, 05 May 2023 17:52:11 +0200, Oswald Buddenhagen wrote: > > On Fri, May 05, 2023 at 05:22:57PM +0200, Takashi Iwai wrote: > > On Fri, 05 May 2023 12:31:35 +0200, > > Oswald Buddenhagen wrote: > >> Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > >> Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx> > >> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> > > > > Here misses your Signed-off-by tag. Ditto for the patch 3. > > It's a legal requirement, and I can't apply patches without it. > > > i assumed reviewed-by would be a superset, but apparently it's not. > however, there is no need to add SOB to patches which i only reviewed > or suggested. SOB is needed by a person who submitted, no matter whether any other tags are present. So, it's still mandatory in this case. > i'll adjust the patches to which i made substantial > modifications, though. Great, thanks! Takashi
