Re: [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 05 May 2023 12:31:35 +0200,
Oswald Buddenhagen wrote:
> 
> From: Jaroslav Kysela <perex@xxxxxxxx>
> 
> The snd_pcm_playback_hw_avail() function uses runtime->status->hw_ptr.
> Unfortunately, in case when we call this function from snd_pcm_update_hw_ptr0(),
> this variable contains the previous hardware pointer. Use the new_hw_ptr
> argument to calculate hw_avail (filled samples by the user space) to
> correct the threshold comparison.
> 
> The new_hw_ptr argument may also be set to ULONG_MAX which means the
> initialization phase. In this case, use runtime->status->hw_ptr.
> 
> Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>
> Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx>
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>

Here misses your Signed-off-by tag.  Ditto for the patch 3.
It's a legal requirement, and I can't apply patches without it.

Could you resubmit the series quickly with your SOB?


thanks,

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux