On Thu, May 04, 2023 at 03:33:01PM +0200, Jaroslav Kysela wrote:
On 04. 05. 23 15:28, Takashi Iwai wrote:
Honestly speaking, this is really hard to review.
As most of changes here are the revert of the previous commit,
no they aren't.
I'd rather like to get it
reverted whole once, and re-apply the proper fix gradually.
I fully agree here. Takashi, please, revert the broken patch right now.
actually reverting would include reverting the comments, which would be
just plain stupid.
I think that the review and improving the code may take some days.
i'm not going to deliver anything more on that matter just to satisfy
some arbitrary process. i think the patch does the right thing, with the
right granularity, and i'm not going to spend time breaking my head on
producing broken intermediate states which i cannot properly reason
about due to their internal inconsistency.
you can "rebase" my patch by checking it out on top of a partial revert,
but you need to come up with your own commit message then. and i think
that it would be utterly counterproductive. viewing the diff for review
purposes may make sense, though.
regards
