On 04. 05. 23 15:28, Takashi Iwai wrote:
On Thu, 04 May 2023 15:00:07 +0200, Oswald Buddenhagen wrote:Turns out that we cannot rely on the application pointer being updated in top-up mode, as its primary purpose is to remain operational in free-running mode as used by dmix. So we logically revert some bits from commit 9f656705c5faa ("ALSA: pcm: rewrite snd_pcm_playback_silence()"), but we retain the bug fixes and try to make the code paths congruent. Reported-by: Jeff Chua <jeff.chua.linux@xxxxxxxxx> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx>Honestly speaking, this is really hard to review. As most of changes here are the revert of the previous commit, I'd rather like to get it reverted whole once, and re-apply the proper fix gradually.
I fully agree here. Takashi, please, revert the broken patch right now. I think that the review and improving the code may take some days.
Jaroslav -- Jaroslav Kysela <perex@xxxxxxxx> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
