--- Begin Message ---
- To: "robh+dt@xxxxxxxxxx" <robh+dt@xxxxxxxxxx>, "broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "tiwai@xxxxxxxx" <tiwai@xxxxxxxx>, "lgirdwood@xxxxxxxxx" <lgirdwood@xxxxxxxxx>, "krzysztof.kozlowski+dt@xxxxxxxxxx" <krzysztof.kozlowski+dt@xxxxxxxxxx>, "matthias.bgg@xxxxxxxxx" <matthias.bgg@xxxxxxxxx>, "perex@xxxxxxxx" <perex@xxxxxxxx>, "angelogioacchino.delregno@xxxxxxxxxxxxx" <angelogioacchino.delregno@xxxxxxxxxxxxx>
- Subject: Re: [PATCH 6/7] ASoC: mediatek: mt8188: add bus protection
- From: Trevor Wu (吳文良) <Trevor.Wu@xxxxxxxxxxxx>
- Date: Thu, 20 Apr 2023 06:44:41 +0000
- Cc: "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-mediatek@xxxxxxxxxxxxxxxxxxx" <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>
- In-reply-to: <23dea66b-27cd-dbeb-37f5-ad9566e50962@collabora.com>
- References: <20230413104713.7174-1-trevor.wu@mediatek.com> <20230413104713.7174-7-trevor.wu@mediatek.com> <23dea66b-27cd-dbeb-37f5-ad9566e50962@collabora.com>
On Thu, 2023-04-13 at 15:19 +0200, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 13/04/23 12:47, Trevor Wu ha scritto: > > Add bus protection for reset controller. > > > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > Is MT8188 the only SoC that will ever use bus protection for reset, > now and > in the future? > > ...otherwise, I think that the best solution here would be to > implement that > into the reset controller itself. > > Regards, > Angelo Hi Angelo, MT8188 is not the only SoC that will use bus protection for reset. I checked with the owner of reset controller. There are some reasons that they prefer to control bus protection by each module which needs reset function individually. First, reset function is only used by few modules. Second, bus protection register for the same module is possibly different in each of SoCs. Finally, bus protect bits are diverse, so it's not easy to implement in reset controller driver. Thanks, Trevor
--- End Message ---
