Re: [PATCH 7/7] ASoC: dt-bindings: mediatek,mt8188-afe: add audio properties

Trevor Wu (吳文良) via Alsa-devel <alsa-devel@xxxxxxxxxxxxxxxx> · Thu, 20 Apr 2023 06:25:16 +0000



--- Begin Message ---

To: "robh+dt@xxxxxxxxxx" <robh+dt@xxxxxxxxxx>,	"krzysztof.kozlowski@xxxxxxxxxx" <krzysztof.kozlowski@xxxxxxxxxx>,	"broonie@xxxxxxxxxx" <broonie@xxxxxxxxxx>, "tiwai@xxxxxxxx" <tiwai@xxxxxxxx>,	"lgirdwood@xxxxxxxxx" <lgirdwood@xxxxxxxxx>,	"krzysztof.kozlowski+dt@xxxxxxxxxx" <krzysztof.kozlowski+dt@xxxxxxxxxx>,	"matthias.bgg@xxxxxxxxx" <matthias.bgg@xxxxxxxxx>, "perex@xxxxxxxx"	<perex@xxxxxxxx>, "angelogioacchino.delregno@xxxxxxxxxxxxx"	<angelogioacchino.delregno@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/7] ASoC: dt-bindings: mediatek,mt8188-afe: add audio properties
From: Trevor Wu (吳文良) <Trevor.Wu@xxxxxxxxxxxx>
Date: Thu, 20 Apr 2023 06:25:16 +0000
Cc: "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-mediatek@xxxxxxxxxxxxxxxxxxx" <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "devicetree@xxxxxxxxxxxxxxx" <devicetree@xxxxxxxxxxxxxxx>
In-reply-to: <47f27da1-8ed1-327e-74d7-ad4e3f12e3d6@linaro.org>
References: <20230413104713.7174-1-trevor.wu@mediatek.com>	 <20230413104713.7174-8-trevor.wu@mediatek.com>	 <310e8979-de96-dda8-6c95-0e6033d8b403@linaro.org>	 <b9daeea6d823b8e84db0ca0df0e04d3716a6b944.camel@mediatek.com>	 <382bc15e-f4e3-3a9f-9dbc-4d46ac1d76d6@collabora.com>	 <3fe703c1279bf4d25a890b63c23a4bc97abd4198.camel@mediatek.com>	 <47f27da1-8ed1-327e-74d7-ad4e3f12e3d6@linaro.org>

On Tue, 2023-04-18 at 14:25 +0200, Krzysztof Kozlowski wrote:
> On 18/04/2023 12:23, Trevor Wu (吳文良) wrote:
> > > Actually, doing that is borderline-ok... there's no devicetree
> > > for
> > > MT8188
> > > upstream, so that's not breaking anything at all.
> > > In any case, I agree that you should generally avoid doing that
> > > but I
> > > think
> > > that in this specific case it's fine; I'm not a devicetree
> > > maintainer
> > > though.
> > > 
> > > P.S.: Trevor, next time please make reviewers aware of the fact
> > > that
> > > no 8188
> > >        devicetree is present upstream!
> > > 
> > 
> > Got it. Thanks.
> > 
> > 
> > Hi krzysztof,
> > 
> > Because there is no upstream mt8188 DTS, should I move the new
> > clock to
> > the end of clock list?
> 
> What is the reason to add them in the middle? So far there was no
> argument, so always add at the end. If you have an argument, let's
> discuss it.
> 
No special reason. Just hope to sort the clock by the clock type.
But it's possible to extend the clock list after we upstream MT8188
DTS, so it won't follow the order finally.
I think it is fine to put the clock at the end. I will move it to the
end in V2.

> > 
> > If I move "apll1_d4" to the end of the list at binding file, when I
> > upstream the devicetree node existing clocks and clock-names
> > properties
> > , should I follow the sequence defined in dt-bindings
> 
> If you do not follow the sequence of bindings, you upstream incorrect
> DTS which does not follow ABI and fails the tests. Therefore yes, use
> the same order as your bindings define.
> 
> > or can I have a
> > new sequence based on the clock type or alphabet?
> 
> Sorry, I don't know what is the order of clock type and alphabet. If
> you
> mean anything else than bindings, then no, because how is it supposed
> to
> work then?
> 
> 
Got it. Thanks for the detailed explanation.
I will follow the order as bindings when I update the DTS node.


Thanks,
Trevor

--- End Message ---