On 17/04/2023 17:58, Mark Brown wrote:
> On Mon, Apr 17, 2023 at 05:43:03PM +0200, Krzysztof Kozlowski wrote:
>> On 17/04/2023 17:33, Mark Brown wrote:
>>> On Mon, Apr 17, 2023 at 04:14:51PM +0200, Krzysztof Kozlowski wrote:
>
>>>> - if (IS_ERR(wcd->if_regmap)) {
>>>> - dev_err(dev, "Failed to allocate ifc register map\n");
>>>> - return PTR_ERR(wcd->if_regmap);
>>>> - }
>>>> + if (IS_ERR(wcd->if_regmap))
>>>> + return dev_err_probe(dev, PTR_ERR(wcd->if_regmap),
>>>> + "Failed to allocate ifc register map\n");
>
>>> This is a functional change.
>
>> Hmm... I don't see it. Return value is the same, same message is
>> printed, same condition. Did I make some copy-paste error?
>
> You've replaced an unconditional dev_err() with dev_err_probe().
Which is the core of this change... so what is here surprising? Yes,
that's functional change and I never wrote that dev_err_probe is equal
dev_err. It is similar but offers benefits and one difference - does not
print DEFER. Which is in general exactly what we want.
Best regards,
Krzysztof
