On Tue, 28 Mar 2023, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. My goodness! It's been a long time since I've seen anything quite like this. My suggestion to you: * Split this up into components that fit functional subsystems * Run checkpatch.pl * Remove all of the debug prints * Move all of the defines out to a header file * Be more verbose in your documentation / comments * Consider using simple-mfd to probe child devices. > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > --- > drivers/mfd/Kconfig | 17 + > drivers/mfd/Makefile | 1 + > drivers/mfd/pef2256.c | 1355 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/pef2256.h | 28 + > 4 files changed, 1401 insertions(+) > create mode 100644 drivers/mfd/pef2256.c > create mode 100644 include/linux/mfd/pef2256.h -- Lee Jones [李琼斯]
