On Wed, Mar 29, 2023 at 04:38:07PM +0100, Richard Fitzgerald wrote: > On 29/3/23 15:37, Jianhua Lu wrote: > > On Wed, Mar 29, 2023 at 02:05:24PM +0000, Charles Keepax wrote: > >> > >> This direction seems slightly problematic, especially in the > >> context of amps (which I presume this relates to, please let know > >> if that is wrong). It would probably be better to be fixing > >> things up such that the amp in question sets system_name when > >> registered through DT. Generally speaking the idea is the amp > > I also consider setting system_name when registered by DT, but I don't > > known setting what name to it. Card name or something else? > > It just has to be a unique string. > The normal process is that Cirrus would release the firmware with the > correct name for the platform, so the system-name matches the string in > those release firmware files. > > Do you have an official firmware for your platform? My device is Xiaomi Pad 5 Pro, vendor releases wmfw firmware with default name, coeff firmware with prefix name(TL, TR and BL, BR....), don't contain a unique string in firmware name. > > >> > >> Thanks, > >> Charles