--- Begin Message ---
- To: Jianhua Lu <lujianhua000@xxxxxxxxx>, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Asoc: wm_adsp: Add support for loading firmware with prefix name
- From: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 29 Mar 2023 16:38:07 +0100
- Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Simon Trimmer <simont@xxxxxxxxxxxxxxxxxxxxx>, Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>, patches@xxxxxxxxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ~postmarketos/upstreaming@xxxxxxxxxxx, phone-devel@xxxxxxxxxxxxxxx
- In-reply-to: <ZCRNRhI3+6jUbqvy@Gentoo>
- References: <20230329130525.15830-1-lujianhua000@gmail.com> <20230329140524.GU68926@ediswmail.ad.cirrus.com> <ZCRNRhI3+6jUbqvy@Gentoo>
- User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0
On 29/3/23 15:37, Jianhua Lu wrote:
On Wed, Mar 29, 2023 at 02:05:24PM +0000, Charles Keepax wrote:
This direction seems slightly problematic, especially in the
context of amps (which I presume this relates to, please let know
if that is wrong). It would probably be better to be fixing
things up such that the amp in question sets system_name when
registered through DT. Generally speaking the idea is the amp
I also consider setting system_name when registered by DT, but I don't
known setting what name to it. Card name or something else?
It just has to be a unique string.
The normal process is that Cirrus would release the firmware with the
correct name for the platform, so the system-name matches the string in
those release firmware files.
Do you have an official firmware for your platform?
tuning is going to be specific to the enclosure/speaker involved,
so a generic tuning for say left amps doesn't really make a lot
of sense.
I don't known about amp tuning much, my need just is loading firmware for
more than 1 speaker amp at the platform using fdt.
One of the both way is good to me.
Thanks,
Charles
--- End Message ---