Re: [PATCH v2 4/4] ASoC: soc-topology.c: remove unnecessary dai_link->platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Peter

Thank you for your feedback

> But in this case the CPU name and the platform name is _not_ identical,
> they are different and we need to have the dummy platform on the FE side
> unconditionally.
(snip)
> sof-audio-pci-intel-tgl 0000:00:1f.3: error: no platforms

Oh, I didn't know that platform is needed on SOF.
Thank you for explaining detail, now I could understand your issue.

In my quick check, each SOF topology might overwrites link->platforms->name
and/or link->platforms->of_node...
I'm not 100% sure about SOF, but I looks strange for me...

I'm not sure which one is better idea, soc-topology.c has dummy platforms
and allow to be overwritten, or each topology alloc own platform if needed.

But I will post the fixup/revert patch for it. Could you please check it ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux