On Fri, Feb 24, 2023 at 02:06:57PM -0500, Nícolas F. R. A. Prado wrote: > Probably the spammiest messages are > [ 33.881459] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_runtime_resume() > [ 33.889320] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_enable_clock() > [ 34.029456] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_runtime_suspend() > [ 34.041718] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_disable_clock() > from mt8192-afe-pcm.c, so I think it would make sense to get rid of those in > this commit as well. They should definitely go as well, I don't know that there's a specific need for it to be this commit though - it was mostly just what I noticed while looking at the controls that were failing tests. > Way less spammy, but there are also > [ 176.209790] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_hw_params(), id 43, rate 48000, channels 2, format 6, mclk_rate 24576000, bck_rate 3072000 > [ 176.224149] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_hw_params(), out_channels_per_sdata = 2 > [ 180.272153] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_en_event(), name TDM_EN, event 0x8 > [ 180.281462] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_bck_en_event(), name TDM_BCK, event 0x8, dai_id 43 > from mt8192-dai-tdm.c. Yup. > Anyway, if you prefer to keep only changes in the ADDA driver for this commit > that's fine too, and I can send another patch removing these other ones later. That'd be great, I will probably take more passes at this stuff at some point but it's very much a background thing.
Attachment:
signature.asc
Description: PGP signature
