On Fri, Feb 24, 2023 at 02:03:55PM +0000, Mark Brown wrote: > There are a lot of info level log messages in the mt8192 ADDA driver which > are trivially triggerable from userspace, many in normal operation. Remove > these to avoid spamming the console. > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> Probably the spammiest messages are [ 33.881459] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_runtime_resume() [ 33.889320] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_enable_clock() [ 34.029456] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_runtime_suspend() [ 34.041718] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mt8192_afe_disable_clock() from mt8192-afe-pcm.c, so I think it would make sense to get rid of those in this commit as well. Way less spammy, but there are also [ 176.209790] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_hw_params(), id 43, rate 48000, channels 2, format 6, mclk_rate 24576000, bck_rate 3072000 [ 176.224149] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_dai_tdm_hw_params(), out_channels_per_sdata = 2 [ 180.272153] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_en_event(), name TDM_EN, event 0x8 [ 180.281462] mt8192-audio 11210000.syscon:mt8192-afe-pcm: mtk_tdm_bck_en_event(), name TDM_BCK, event 0x8, dai_id 43 from mt8192-dai-tdm.c. Anyway, if you prefer to keep only changes in the ADDA driver for this commit that's fine too, and I can send another patch removing these other ones later. Either way, Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> Thanks, Nícolas
