On 1/27/2023 2:38 PM, Pierre-Louis Bossart wrote:
On 1/27/23 05:12, Amadeusz Sławiński wrote:
On 1/25/2023 4:15 PM, Pierre-Louis Bossart wrote:
On 1/25/23 13:46, Amadeusz Sławiński wrote:
Functions removing bytes, enum and mixer kcontrols are identical. Unify
they are identical because of the change in patch10.
Please clarify that this is not a cleanup removing duplicated code
that's been there forever, it's become useless as a result of the
previous patch.
There is no dependency on previous patch - it is just order I've send
them in - those functions have same implementation in current code.
Not following, sorry. What is this addition in patch 10?
diff --git a/include/sound/soc-topology.h b/include/sound/soc-topology.h
index b4b896f83b94..f055c6917f6c 100644
--- a/include/sound/soc-topology.h
+++ b/include/sound/soc-topology.h
@@ -62,7 +62,7 @@ struct snd_soc_dobj {
enum snd_soc_dobj_type type;
unsigned int index; /* objects can belong in different groups */
struct list_head list;
- struct snd_soc_tplg_ops *ops;
+ int (*unload)(struct snd_soc_component *comp, struct snd_soc_dobj *dobj);
That's not in 'current code', is it? How is this not a dependency?
It only depends on it because of order I did changes in, but there is
really no dependency here. I will send v2 with reversed order.
