On Tue, Dec 13, 2022 at 11:37:56AM -0700, Shuah Khan wrote: > On 12/13/22 11:32, Nícolas F. R. A. Prado wrote: > > The default timeout for kselftests is 45 seconds, but pcm-test can take > > longer than that to run depending on the number of PCMs present on a > > device. > > > > As a data point, running pcm-test on mt8192-asurada-spherion takes about > > 1m15s. > > > > Set the timeout to 10 minutes, which should give enough slack to run the > > test even on devices with many PCMs. > > > > 10 minutes is way too long. > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > > > > --- > > > > tools/testing/selftests/alsa/settings | 1 + > > 1 file changed, 1 insertion(+) > > create mode 100644 tools/testing/selftests/alsa/settings > > > > diff --git a/tools/testing/selftests/alsa/settings b/tools/testing/selftests/alsa/settings > > new file mode 100644 > > index 000000000000..a62d2fa1275c > > --- /dev/null > > +++ b/tools/testing/selftests/alsa/settings > > @@ -0,0 +1 @@ > > +timeout=600 > > Adding timeouts like this especially 10 minutes will increase the time > it takes to run tests. We run the risk of people not wanting to run tests > anymore. I set it high because I suspect the time it takes to run pcm-test might be a lot higher in some machines (even on mt8192-asurada-spherion, it takes 1m15s, but only ~10% of the tests are actually running, since many of the PCMs are disabled). But I can lower it to, say, 3 minutes, and we can increase the timeout as needed. Thanks, Nícolas
