Re: [PATCH] kselftest/alsa: Increase kselftest timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/22 11:32, Nícolas F. R. A. Prado wrote:
The default timeout for kselftests is 45 seconds, but pcm-test can take
longer than that to run depending on the number of PCMs present on a
device.

As a data point, running pcm-test on mt8192-asurada-spherion takes about
1m15s.

Set the timeout to 10 minutes, which should give enough slack to run the
test even on devices with many PCMs.


10 minutes is way too long.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

---

  tools/testing/selftests/alsa/settings | 1 +
  1 file changed, 1 insertion(+)
  create mode 100644 tools/testing/selftests/alsa/settings

diff --git a/tools/testing/selftests/alsa/settings b/tools/testing/selftests/alsa/settings
new file mode 100644
index 000000000000..a62d2fa1275c
--- /dev/null
+++ b/tools/testing/selftests/alsa/settings
@@ -0,0 +1 @@
+timeout=600

Adding timeouts like this especially 10 minutes will increase the time
it takes to run tests. We run the risk of people not wanting to run tests
anymore.

thanks,
-- Shuah





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux