On Mon, Dec 05, 2022 at 05:00:52PM +0100, Greg KH wrote:
> On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > device_remove() => bus->remove() => driver->remove()
> >
> > Driver core needs no feedback from bus driver about the result of
> > remove callback. In which case, commit fc7a6209d571 ("bus: Make
> > remove callback return void") forces bus_type::remove be void-returned.
> >
> > Now we have the situation that both 1st & 2nd part of calling chain
> > are void returned, so it does not make much sense for the last one
> > (driver->remove) to return non-void to its caller.
> >
> > So the basic idea behind this patchset is making remove() callback of
> > any bus-based driver to be void returned.
> >
> > This patchset includes changes for drivers below:
> > 1. hyperv
> > 2. macio
> > 3. apr
> > 4. xen
> > 5. ac87
> > 6. soundbus
Hi Greg:
Thanks for the reviewing.
>
> Then that should be 6 different patchsets going to 6 different
> subsystems. No need to make this seems like a unified set of patches at
> all.
Right, will fix all the issues for this patchset and resend them in 6
independent patches.
Thanks
Dawei
>
> > Q: Why not platform drivers?
> > A: Too many of them.(maybe 4K+)
>
> That will have to be done eventually, right?
>
> thanks,
>
> greg k-h
