Re: [PATCH 6/6] soundwire: qcom: add support for v1.7 Soundwire Controller

[Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>]

Hi Pierre,

On 26/10/2022 21:14, Pierre-Louis Bossart wrote:
> > @@ -1582,6 +1597,7 @@ static const struct of_device_id qcom_swrm_of_match[] = {
> >   	{ .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data },
> >   	{ .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data },
> >   	{ .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_6_data },
> > +	{ .compatible = "qcom,soundwire-v1.7.0", .data = &swrm_v1_5_data },
>
> is this line intentional, it looks odd that 1.7 is compatible with 1.5,
> but 1.6 isn't?
This is more around the data rather than compatible, 1.6 data is marked 
with sw_clk_gate_required = true which is not the case with 1.7.

from 1.5 we use same frame shape info for 1.6, 1.7, except that 1.6 had 
this sw_clk_gate_required flag set.

--srini

>