On Wed, Oct 26, 2022 at 07:28:26AM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > On Tue, Oct 25, 2022 at 10:56:11PM +0800, wangkailong@xxxxxxx wrote: > > > sound/soc/soc-ops.c:817: WARNING opportunity for min() > > > kfree(uctl); > > > - return err < 0 ? err : 0; > > > + return min(err, 0); > > I don't think this is a good warning, while I'm no big fan of the > > ternery operator the new code is less clear about the intent than the > > old code. > Agreed. That use of ternery is a standard idiom. > If we have to eliminate the use of ternery inevitably, it'd be better > to introduce a new macro for clarity instead. It looks like it's more about identifying a pattern that could be min() but not being able to detect the semantics of why we're comparing numbers.
Attachment:
signature.asc
Description: PGP signature
