On Tue, 25 Oct 2022 19:01:32 +0200, Mark Brown wrote: > > On Tue, Oct 25, 2022 at 10:56:11PM +0800, wangkailong@xxxxxxx wrote: > > Fix the following coccicheck warning: > > > > sound/soc/soc-ops.c:817: WARNING opportunity for min() > > > kfree(uctl); > > - return err < 0 ? err : 0; > > + return min(err, 0); > > I don't think this is a good warning, while I'm no big fan of the > ternery operator the new code is less clear about the intent than the > old code. Agreed. That use of ternery is a standard idiom. If we have to eliminate the use of ternery inevitably, it'd be better to introduce a new macro for clarity instead. thanks, Takashi
