Hello Dan, On Thu, 8 Sep 2022 16:35:19 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > Hi, > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/luca-ceresoli-bootlin-com/Add-support-for-the-internal-RK3308-audio-codec/20220907-222555 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > config: arc-randconfig-m031-20220908 (https://download.01.org/0day-ci/archive/20220908/202209082103.F4ICyyHT-lkp@xxxxxxxxx/config) > compiler: arceb-elf-gcc (GCC) 12.1.0 > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > smatch warnings: > sound/soc/codecs/rk3308_codec.c:748 rk3308_set_dai_fmt() error: uninitialized symbol 'is_master'. > sound/soc/codecs/rk3308_codec.c:998 rk3308_codec_digital_fadeout() warn: always true condition '(l_dgain >= (0 << 0)) => (0-u32max >= 0)' > sound/soc/codecs/rk3308_codec.c:998 rk3308_codec_digital_fadeout() warn: always true condition '(l_dgain >= (0 << 0)) => (0-u32max >= 0)' > > vim +/is_master +748 sound/soc/codecs/rk3308_codec.c > > 786c160ad64ae5 Luca Ceresoli 2022-09-07 680 static int rk3308_set_dai_fmt(struct snd_soc_dai *codec_dai, > 786c160ad64ae5 Luca Ceresoli 2022-09-07 681 unsigned int fmt) > 786c160ad64ae5 Luca Ceresoli 2022-09-07 682 { > 786c160ad64ae5 Luca Ceresoli 2022-09-07 683 struct snd_soc_component *component = codec_dai->component; > 786c160ad64ae5 Luca Ceresoli 2022-09-07 684 struct rk3308_codec_priv *rk3308 = snd_soc_component_get_drvdata(component); > 786c160ad64ae5 Luca Ceresoli 2022-09-07 685 const unsigned int inv_bits = fmt & SND_SOC_DAIFMT_INV_MASK; > 786c160ad64ae5 Luca Ceresoli 2022-09-07 686 const bool inv_bitclk = > 786c160ad64ae5 Luca Ceresoli 2022-09-07 687 (inv_bits & SND_SOC_DAIFMT_IB_IF) || > 786c160ad64ae5 Luca Ceresoli 2022-09-07 688 (inv_bits & SND_SOC_DAIFMT_IB_NF); > 786c160ad64ae5 Luca Ceresoli 2022-09-07 689 const bool inv_frmclk = > 786c160ad64ae5 Luca Ceresoli 2022-09-07 690 (inv_bits & SND_SOC_DAIFMT_IB_IF) || > 786c160ad64ae5 Luca Ceresoli 2022-09-07 691 (inv_bits & SND_SOC_DAIFMT_NB_IF); > 786c160ad64ae5 Luca Ceresoli 2022-09-07 692 > 786c160ad64ae5 Luca Ceresoli 2022-09-07 693 unsigned int adc_aif1 = 0, adc_aif2 = 0, dac_aif1 = 0, dac_aif2 = 0; > 786c160ad64ae5 Luca Ceresoli 2022-09-07 694 int grp, is_master; > > is_master needs to be initialized to false. Fixed both, and also made is_master a bool for clarity. Changes queued for v2. Thank you. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
